[4.3] Allow compiling with warnings with min macOS version up to 14 - #122564
Open
aaronfranke wants to merge 1 commit into
Open
[4.3] Allow compiling with warnings with min macOS version up to 14#122564aaronfranke wants to merge 1 commit into
aaronfranke wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem(s) does this PR solve?
This PR fixes Godot 4.3's Objective-C++ code to allow compiling with newer minimum macOS versions, up to macOS 14.0.
Justification: We should give users the flexibility to customize the minimum macOS version if they need to, such as if a dependency requires a newer minimum macOS version. This adds longevity to the 4.3 branch for macOS.
Additional information
No AI was used to make this PR.
A dedicated PR is required to backport this to 4.2 and earlier due to conflicts.
The version numbers after
#if MAC_OS_X_VERSION_MIN_REQUIREDcorrespond to exactly the version in which those features become deprecated and therefore stop compiling when warnings are enabled.I tested with up to macOS 26.5, and the only remaining problem with going that far is
CGWindowListCreateImageFromArraywhich is deprecated as of macOS 15.0. This will require migration toScreenCaptureKit.This PR can be considered a further backport of PR #122563. However, I also had to include pieces of PR #95854 and PR #99350 in order to retain the same functionality without calling deprecated APIs.